Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several updates/fixes to the options passed to browsers #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solonovamax
Copy link

This PR adds the following changes:

  • Extract common options from ChromeBrowser and ChromiumBrowser.
    • Introduce function getOptions instead of duplicating code.
    • Introduce options to chromium for parity.
      Previously, chrome had these options added to it to fix a bug, however they were not added to chromium.
      • Add --disable-renderer-backgrounding to chromium
      • Add --disable-device-discovery-notifications to chromium
  • Introduce new options.
    • Introduce options to prevent password dialogues when running tests.
      • Add --password-store=basic. Prevents gnome keyring/kde wallet popup on Linux.
      • Add --use-mock-keychain. Prevents permissions dialog on Mac.
    • Introduce options to disable interactivity.
      • Add --disable-popup-blocking. Disables the "block popups" dialog.
      • Add --disable-notifications. Disable notifications.
      • Add --mute-audio. Mute audio.
      • Add --disable-client-side-phishing-detection. Disables client-side phishing detection.
    • Replace removed flags
      • Replace --disable-translate with --disable-features=Translate

I personally was running into an issue with the lack of --password-store=basic causing chromium to repeatedly prompt for a password when running tests. Originally, this PR was going to only introduce that flag, however while modifying the code to add this, I noticed a few other minor changes I could do, which is why this PR contains a few changes.

If any of the new flags introduced are blocking a merge, then I can remove them, as I'd like to get --password-store=basic merged.

- Extract common options from ChromeBrowser and ChromiumBrowser
  - Introduce function `getOptions`
  - Introduce options to chromium for parity
    - Add --disable-renderer-backgrounding
    - Add --disable-device-discovery-notifications
- Introduce new options
  - Introduce options to prevent password dialogs when running tests
    - Add --password-store=basic. Prevents gnome keyring/kde wallet popup on Linux
    - Add --use-mock-keychain. Prevents permissions dialog on Mac.
  - Introduce options to disable interactivity
    - Add --disable-popup-blocking
    - Add --disable-notifications
    - Add --mute-audio
    - Add --disable-client-side-phishing-detection
  - Replace removed flags
    - Replace --disable-translate with --disable-features=Translate
@google-cla
Copy link

google-cla bot commented Jul 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant