App: Fix openstack-operator app installation #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the information on whether to create an operator group comes from the olm spec of the operator |
But we are still creating it after this patch, we are just not restricting it to a single namespaces. |
|
|
|
You can see in that picture the default behavior on the UI, and that is the Installation mode to be for All namespaces on the cluster, which is what this change does. |
Currently whenever an operator defines a preferred installation namespace we limit it's installation mode to that specific namespace of the cluster. This goes against the default behavior of the web console, where the default (if the operator supports it) is to install it for all namespaces of the cluster. In this patch we change kcli to behave like the web console, so even if the operator is installed in the desired namespace it will only be restricted to that namespace if it doesn't support `AllNamespaces`. This is important because there are operators, like the openstack operator, that expects them to handle all the namespaces. When that's not the case the installation of OpenStack in OpenShift (following deployment guides) will not work, and we'll get the following error when creating a valid `OpenStackControlPlane` object in the `openstack` namespace: ``` The OpenStackControlPlane "rhoso" is invalid: * spec.galera.templates.openstack.storageClass: Required value * spec.galera.templates.openstack-cell1.storageClass: Required value * spec.glance.template.glanceAPIs.default.containerImage: Required value * spec.glance.template.imageCache: Required value * spec.barbican.template.serviceAccount: Required value * spec.nova.template.apiContainerImageURL: Required value * spec.nova.template.computeContainerImageURL: Required value * spec.nova.template.conductorContainerImageURL: Required value * spec.nova.template.metadataContainerImageURL: Required value * spec.nova.template.novncproxyContainerImageURL: Required value * spec.nova.template.schedulerContainerImageURL: Required value * <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation ``` This is because the mutating webhooks are restricted by the `targetNamespaces`.
Akrog
force-pushed
the
fix-openstack-operator
branch
from
3387e0a to
9dba5bd
Compare
|
I have made a change to the approach, now I use the information from the package manifest ( I haven't tested the approach, but if you are ok with this approach I will. |
karmab
force-pushed
the
main
branch
3 times, most recently
from
5e8e6a9 to
39ec49b
Compare
karmab
force-pushed
the
main
branch
4 times, most recently
from
211ad8e to
a05e93a
Compare
karmab
force-pushed
the
main
branch
3 times, most recently
from
202b451 to
3683b77
Compare
karmab
force-pushed
the
main
branch
6 times, most recently
from
28d0b9f to
1ceba51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing the
openstack-operatorit is correctly installed in theopenstack-operatorsnamespace, but because of thiskclialso creates anOperatorGroupthat is limiting the namespaces where it will take effect.This means that following the installation of OpenStack in OpenShift will not work, and we'll get the following error when creating a valid
OpenStackControlPlaneobject in theopenstacknamespace:This is because the mutating webhooks are restricted by the
targetNamespaces.In this patch we make a small change to the
install.yml.j2template so that thetargetNamespacesis not created when deploying the openstack-operator.(cherry picked from commit dee7a94d98b0d50e17a6e8866c4e627fe20c7180)