Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions security-team/security-groups.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ Members:
- Hongcai Ren([@RainbowMango](https://github.com/rainbowmango)), [[email protected]](mailto:[email protected])
- Zhuang Zhang([@zhzhuang-zju](https://github.com/zhzhuang-zju)), [[email protected]](mailto:[email protected])
- Yanfeng Huang([@yanfeng1992](https://github.com/yanfeng1992)), [[email protected]](mailto:[email protected])
- Wenjiang Ding([@warjiang](https://github.com/warjiang)), [[email protected]](mailto:[email protected])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and for consistency with other contributor lists in the repository (e.g., MAINTAINERS.md and REVIEWERS.md), it's good practice to keep this list of members sorted alphabetically by first name.

With your addition, the sorted list would be:

- Hongcai Ren([@RainbowMango](https://github.com/rainbowmango)), [[email protected]](mailto:[email protected])
- Wenjiang Ding([@warjiang](https://github.com/warjiang)), [[email protected]](mailto:[email protected])
- Yanfeng Huang([@yanfeng1992](https://github.com/yanfeng1992)), [[email protected]](mailto:[email protected])
- Zefeng Wang([@Kevin Wang](https://github.com/kevin-wangzefeng)), [[email protected]](mailto:[email protected])
- Zhuang Zhang([@zhzhuang-zju](https://github.com/zhzhuang-zju)), [[email protected]](mailto:[email protected])

This would involve reordering the existing entries as well. Thank you for considering this!