-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/turborepo #56
Conversation
/assign @samzong |
3c25395
to
995d979
Compare
@warjiang Is this ready to move forward? Would you like to rebase, since this PR has been waiting for a while, I don't know if it still passes the CI tests. |
I'll rebase and recheck this PR locally. Need more time~ |
OK. no rush, take your time, just assign it to me once you are ready. |
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
995d979
to
eb5e07e
Compare
@RainbowMango I've rebase the code and re-check the build ci, plz check it again. |
the PR is still large, do I need to split it into multi PRs. Some background is that the feature of this PR(turborepo and ui components) can work standalone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks. Sorry for letting this sit so long.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: