Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/turborepo #56

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Conversation

warjiang
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

  1. implement @karmada/terminal and corresponding addon(zmodem and overlay addon)
  2. introduce turborepo, which is very useful to solve the dependency tree under the ui folder
  3. introduce changeset to gen changelog for ui components under the ui/packages folder

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. implement @karmada/terminal and corresponding addon(zmodem and overlay addon)
2. introduce turborepo and changeset tools

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Jul 10, 2024
@karmada-bot karmada-bot requested review from devadapter and jhnine July 10, 2024 04:36
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 10, 2024
@warjiang
Copy link
Contributor Author

/assign @samzong

@warjiang warjiang force-pushed the feature/turborepo branch from 3c25395 to 995d979 Compare July 10, 2024 06:22
@karmada-bot karmada-bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 10, 2024
@RainbowMango
Copy link
Member

@warjiang Is this ready to move forward? Would you like to rebase, since this PR has been waiting for a while, I don't know if it still passes the CI tests.

@warjiang
Copy link
Contributor Author

@warjiang Is this ready to move forward? Would you like to rebase, since this PR has been waiting for a while, I don't know if it still passes the CI tests.

I'll rebase and recheck this PR locally. Need more time~

@RainbowMango
Copy link
Member

OK. no rush, take your time, just assign it to me once you are ready.

@warjiang
Copy link
Contributor Author

@RainbowMango I've rebase the code and re-check the build ci, plz check it again.

@warjiang
Copy link
Contributor Author

@RainbowMango I've rebase the code and re-check the build ci, plz check it again.

the PR is still large, do I need to split it into multi PRs. Some background is that the feature of this PR(turborepo and ui components) can work standalone.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks. Sorry for letting this sit so long.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@karmada-bot karmada-bot merged commit e26300e into karmada-io:main Aug 26, 2024
4 checks passed
@warjiang warjiang deleted the feature/turborepo branch October 23, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants