fix ci build error #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/bug
karmada-bot
added
the
size/XS
Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
warjiang
force-pushed
the
fix/ui-workload-build
branch
from
3bd889e to
3ea223d
Compare
|
/assign @RainbowMango |
RainbowMango
added
the
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
axif0
pushed a commit
to axif0/dashboard
that referenced
this pull request
Aug 9, 2024
* fix: update invoke of GetNamespaces Signed-off-by: warjiang <[email protected]> * ci: only build and push image in karmada-io/dashboard repo Signed-off-by: warjiang <[email protected]> --------- Signed-off-by: warjiang <[email protected]> Signed-off-by: axif <[email protected]>
axif0
pushed a commit
to axif0/dashboard
that referenced
this pull request
Aug 12, 2024
* fix: update invoke of GetNamespaces Signed-off-by: warjiang <[email protected]> * ci: only build and push image in karmada-io/dashboard repo Signed-off-by: warjiang <[email protected]> --------- Signed-off-by: warjiang <[email protected]> Signed-off-by: axif <[email protected]>
chouchongYHMing
pushed a commit
to chouchongYHMing/dashboard
that referenced
this pull request
Aug 26, 2024
* fix: update invoke of GetNamespaces Signed-off-by: warjiang <[email protected]> * ci: only build and push image in karmada-io/dashboard repo Signed-off-by: warjiang <[email protected]> --------- Signed-off-by: warjiang <[email protected]> Signed-off-by: chouchongYHMing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Fix ci build error：
CI build error 👉🏻：https://github.com/karmada-io/dashboard/actions/runs/10279472346/job/28444903136
in the PR: https://github.com/karmada-io/dashboard/pull/61/files
I updated the signature of
GetNamespaceshttps://github.com/karmada-io/dashboard/blob/48a9a9740c3a2c3436fb1319d68579e78a7af9c3/ui/apps/dashboard/src/services/namespace.ts#L17C1-L30C2
But did not update the invoke of
GetNamespacesinsrc/pages/multicloud-resource-manage/workload/index.tsxhttps://github.com/karmada-io/dashboard/blob/48a9a9740c3a2c3436fb1319d68579e78a7af9c3/ui/apps/dashboard/src/pages/multicloud-resource-manage/workload/index.tsx#L34C3-L40C6
Then it caused one typescript error.
Optimize ci push image:
I always receive ci push image error as following
so I decided to execute push image conditionally, only push images for repo
karmada-io/dashboardSpecial notes for your reviewer:
After solve the ci build error, i'll continue the process of resolving conflict
Does this PR introduce a user-facing change?: