Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for configmap management #86

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

warjiang
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

  1. add store management, we use zustand now
  2. ui for configmap management
    Which issue(s) this PR fixes:
    Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- implement management for configmap under the config
- introduct zustand as store management

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 13, 2024
@warjiang
Copy link
Contributor Author

/hold

@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 13, 2024
@warjiang
Copy link
Contributor Author

@RainbowMango
Copy link
Member

This PR should be reviewed after

The two PRs get merged, but you have to rebase and resolve the conflicts.

@warjiang
Copy link
Contributor Author

This PR should be reviewed after

The two PRs get merged, but you have to rebase and resolve the conflicts.

I'll solve conflicts asap~.

@warjiang warjiang force-pushed the feature/configmap-manage-ui branch from c2a6915 to 8aacca8 Compare August 19, 2024 07:49
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 19, 2024
@warjiang
Copy link
Contributor Author

This PR should be reviewed after

The two PRs get merged, but you have to rebase and resolve the conflicts.

After rebase main, this PR seems much smaller than before 😄 .
@RainbowMango Let's move forward~

@RainbowMango
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
@karmada-bot karmada-bot merged commit 922deee into karmada-io:main Aug 19, 2024
4 checks passed
@warjiang warjiang deleted the feature/configmap-manage-ui branch October 23, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants