fix: kind cluster config member2 #87
Conversation
|
Welcome @shauvet! It looks like this is your first PR to karmada-io/dashboard 🎉 |
karmada-bot
added
the
size/XS
| @@ -2,6 +2,7 @@ | |||
| kind: Cluster | |||
| apiVersion: "kind.x-k8s.io/v1alpha4" | |||
| networking: | |||
| apiServerAddress: "{{host_ipaddress}}" | |||
There was a problem hiding this comment.
@shauvet Can you explain why we need this?
There was a problem hiding this comment.
First, when I did local development, without it, I couldn't start my local api server, second, I thought it should be similar with the member1's config. Do I understand wrong?
There was a problem hiding this comment.
Thanks. @shauvet Could you please sign the commit as per https://github.com/karmada-io/dashboard/pull/87/checks?check_run_id=28865035951?
There was a problem hiding this comment.
Thanks. @shauvet Could you please sign the commit as per https://github.com/karmada-io/dashboard/pull/87/checks?check_run_id=28865035951?
OK, done.
|
@shauvet can you resolve the DCO problem ? |
Signed-off-by: xiaowei.yang <[email protected]>
shauvet
force-pushed
the
fix/kindClusterConfig
branch
from
cd80e3b to
f1bbe56
Compare
OK, it's done now. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
What this PR does / why we need it:
For local develepment
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: