Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementing feature of config for karmada dashboard #91

Merged
merged 3 commits into from
Aug 26, 2024
Merged

implementing feature of config for karmada dashboard #91

merged 3 commits into from
Aug 26, 2024

Conversation

warjiang
Copy link
Contributor

What type of PR is this?

/kind feature
What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #74

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- add config for dashboard config, admin can control sidebar menu by editing the `karmada-dashboard-configmap` configmap.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 21, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2024
@warjiang
Copy link
Contributor Author

/assign @RainbowMango @samzong

@warjiang
Copy link
Contributor Author

/retitle implementing feature of config for karmada dashboard

@karmada-bot karmada-bot changed the title Feature/dashboard config implementing feature of config for karmada dashboard Aug 21, 2024
@RainbowMango
Copy link
Member

You might need to resolve the conflicts and rebase.

@warjiang warjiang force-pushed the feature/dashboard-config branch from b3db5e5 to ab5cf5d Compare August 26, 2024 06:37
@warjiang
Copy link
Contributor Author

You might need to resolve the conflicts and rebase.

@RainbowMango The conflict already been resolved 🏁

@RainbowMango RainbowMango added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 26, 2024
RainbowMango
RainbowMango approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the structure of this ConfigMap lacks a standard API-style definition, this may bring challenges like, when making changes to the definition, the backward compatibility might be break.

But, for now we can move forward, and wait and see if we need an API for this configuration.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@karmada-bot karmada-bot merged commit 896a226 into karmada-io:main Aug 26, 2024
4 checks passed
chouchongYHMing pushed a commit to chouchongYHMing/dashboard that referenced this pull request Sep 2, 2024
@warjiang @chouchongYHMing
implementing feature of config for karmada dashboard (karmada-io#91)
4da4c6b 
* feat: add config for karmada dashboard

Signed-off-by: warjiang <[email protected]>

* feat: consume dashboard config api in ui

Signed-off-by: warjiang <[email protected]>

* chore: add configmap for dashboard

Signed-off-by: warjiang <[email protected]>

---------

Signed-off-by: warjiang <[email protected]>
Signed-off-by: chouchongYHMing <[email protected]>
chouchongYHMing pushed a commit to chouchongYHMing/dashboard that referenced this pull request Sep 9, 2024
@warjiang @chouchongYHMing
implementing feature of config for karmada dashboard (karmada-io#91)
df6191e 
* feat: add config for karmada dashboard

Signed-off-by: warjiang <[email protected]>

* feat: consume dashboard config api in ui

Signed-off-by: warjiang <[email protected]>

* chore: add configmap for dashboard

Signed-off-by: warjiang <[email protected]>

---------

Signed-off-by: warjiang <[email protected]>
Signed-off-by: chouchongYHMing <[email protected]>
@warjiang warjiang deleted the feature/dashboard-config branch October 23, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@devadapter devadapter Awaiting requested review from devadapter

@samzong samzong Awaiting requested review from samzong

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config for karmada dashboard
3 participants
@warjiang @RainbowMango @karmada-bot