Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace hard-coded karmada config secret name with arguments in cert_rotation controller #5761

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace hard-coded karmada config secret name with arguments in cert_rotation controller #5761

wants to merge 1 commit into from

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

replace hard-coded karmada config secret name with arguments in cert_rotation controller

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-agent`: add two command arguments to specify karmada config secret name for cert rotation controller

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 31, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@chaosi-zju
Copy link
Member Author

/cc @zhzhuang-zju

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 42.25%. Comparing base (9c0bd72) to head (c234502).

Files with missing lines Patch % Lines
cmd/agent/app/agent.go 0.00% 2 Missing ⚠️
cmd/agent/app/options/options.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5761   +/-   ##
=======================================
  Coverage   42.25%   42.25%           
=======================================
  Files         655      655           
  Lines       55756    55760    +4     
=======================================
+ Hits        23561    23563    +2     
- Misses      30683    30685    +2     
  Partials     1512     1512
Flag Coverage Δ
unittests 42.25% <55.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor

/assign

zhzhuang-zju
zhzhuang-zju reviewed Nov 1, 2024
View reviewed changes
cmd/agent/app/options/options.go
Comment on lines +217 to +218
fs.StringVar(&o.KarmadaKubeconfigName, "karmada-kubeconfig-name", "karmada-kubeconfig", "Name of the secret containing karmada-agent certificate. This is only applicable if cert rotation is enabled.")
fs.StringVar(&o.KarmadaKubeconfigFeild, "karmada-kubeconfig-field", "karmada-kubeconfig", "Field name of the karmada config secret containing karmada-agent certificate. This is only applicable if cert rotation is enabled.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you complete #5363, will the default value of flag karmada-kubeconfig-name change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be completed together with the standardization of the karmada-agent secret name, or can the secret name be dynamically obtained using the karmada-agent manifest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzhuang-zju zhzhuang-zju zhzhuang-zju left review comments

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@whitewindmills whitewindmills Awaiting requested review from whitewindmills

Assignees

@zhzhuang-zju zhzhuang-zju

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaosi-zju @karmada-bot @codecov-commenter @zhzhuang-zju