-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local up installation failed on macOS duo to missing envsubst #5990
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: chaosi-zju <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5990 +/- ##
==========================================
+ Coverage 48.24% 48.25% +0.01%
==========================================
Files 665 665
Lines 54797 54797
==========================================
+ Hits 26435 26441 +6
+ Misses 26645 26639 -6
Partials 1717 1717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested?
Yes, I tested by run $ kubectl get secret -A
NAMESPACE NAME TYPE DATA AGE
karmada-system etcd-cert kubernetes.io/tls 3 2m50s
karmada-system etcd-etcd-client-cert kubernetes.io/tls 3 2m49s
karmada-system karmada-aggregated-apiserver-cert kubernetes.io/tls 3 2m51s
karmada-system karmada-aggregated-apiserver-config Opaque 1 2m47s
karmada-system karmada-aggregated-apiserver-etcd-client-cert kubernetes.io/tls 3 2m49s
karmada-system karmada-apiserver-cert kubernetes.io/tls 3 2m51s
karmada-system karmada-apiserver-etcd-client-cert kubernetes.io/tls 3 2m49s
karmada-system karmada-apiserver-front-proxy-client-cert kubernetes.io/tls 3 2m49s
karmada-system karmada-apiserver-service-account-key-pair Opaque 2 2m47s
karmada-system karmada-controller-manager-config Opaque 1 2m47s
karmada-system karmada-descheduler-config Opaque 1 2m46s
karmada-system karmada-descheduler-scheduler-estimator-client-cert kubernetes.io/tls 3 2m48s
karmada-system karmada-interpreter-webhook-example-cert kubernetes.io/tls 3 2m50s
karmada-system karmada-interpreter-webhook-example-config Opaque 1 2m45s
karmada-system karmada-metrics-adapter-cert kubernetes.io/tls 3 2m51s
karmada-system karmada-metrics-adapter-config Opaque 1 2m46s
karmada-system karmada-scheduler-config Opaque 1 2m46s
karmada-system karmada-scheduler-scheduler-estimator-client-cert kubernetes.io/tls 3 2m48s
karmada-system karmada-search-cert kubernetes.io/tls 3 2m50s
karmada-system karmada-search-config Opaque 1 2m46s
karmada-system karmada-search-etcd-client-cert kubernetes.io/tls 3 2m49s
karmada-system karmada-webhook-cert kubernetes.io/tls 3 2m50s
karmada-system karmada-webhook-config Opaque 1 2m46s
karmada-system kube-controller-manager-ca-cert kubernetes.io/tls 2 2m48s
karmada-system kube-controller-manager-config Opaque 1 2m47s
karmada-system kube-controller-manager-service-account-key-pair Opaque 2 2m48s
karmada-system member1-kubeconfig Opaque 1 68s
karmada-system member2-kubeconfig Opaque 1 63s
karmada-system member3-kubeconfig Opaque 1 62s |
Tested on MacOS? |
No, Karmada has not ever been successfully installed by Hi @hongshaoyang, can you please help check whether this PR can resolve your issue? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix local up installation failed on macOS duo to missing envsubst by default.
Which issue(s) this PR fixes:
Fixes #5934
Special notes for your reviewer:
Does this PR introduce a user-facing change?: