Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local up installation failed on macOS duo to missing envsubst #5990

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix local up installation failed on macOS duo to missing envsubst by default.

Which issue(s) this PR fixes:

Fixes #5934

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhzhuang-zju for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.25%. Comparing base (337c27b) to head (3f305f5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5990      +/-   ##
==========================================
+ Coverage   48.24%   48.25%   +0.01%     
==========================================
  Files         665      665              
  Lines       54797    54797              
==========================================
+ Hits        26435    26441       +6     
+ Misses      26645    26639       -6     
  Partials     1717     1717              
Flag Coverage Δ
unittests 48.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested?

@chaosi-zju
Copy link
Member Author

Have you tested?

Yes, I tested by run local-up-karmada.sh and check whether realted secrets generated success:

$ kubectl get secret -A            
NAMESPACE        NAME                                                  TYPE                            DATA   AGE
karmada-system   etcd-cert                                             kubernetes.io/tls               3      2m50s
karmada-system   etcd-etcd-client-cert                                 kubernetes.io/tls               3      2m49s
karmada-system   karmada-aggregated-apiserver-cert                     kubernetes.io/tls               3      2m51s
karmada-system   karmada-aggregated-apiserver-config                   Opaque                          1      2m47s
karmada-system   karmada-aggregated-apiserver-etcd-client-cert         kubernetes.io/tls               3      2m49s
karmada-system   karmada-apiserver-cert                                kubernetes.io/tls               3      2m51s
karmada-system   karmada-apiserver-etcd-client-cert                    kubernetes.io/tls               3      2m49s
karmada-system   karmada-apiserver-front-proxy-client-cert             kubernetes.io/tls               3      2m49s
karmada-system   karmada-apiserver-service-account-key-pair            Opaque                          2      2m47s
karmada-system   karmada-controller-manager-config                     Opaque                          1      2m47s
karmada-system   karmada-descheduler-config                            Opaque                          1      2m46s
karmada-system   karmada-descheduler-scheduler-estimator-client-cert   kubernetes.io/tls               3      2m48s
karmada-system   karmada-interpreter-webhook-example-cert              kubernetes.io/tls               3      2m50s
karmada-system   karmada-interpreter-webhook-example-config            Opaque                          1      2m45s
karmada-system   karmada-metrics-adapter-cert                          kubernetes.io/tls               3      2m51s
karmada-system   karmada-metrics-adapter-config                        Opaque                          1      2m46s
karmada-system   karmada-scheduler-config                              Opaque                          1      2m46s
karmada-system   karmada-scheduler-scheduler-estimator-client-cert     kubernetes.io/tls               3      2m48s
karmada-system   karmada-search-cert                                   kubernetes.io/tls               3      2m50s
karmada-system   karmada-search-config                                 Opaque                          1      2m46s
karmada-system   karmada-search-etcd-client-cert                       kubernetes.io/tls               3      2m49s
karmada-system   karmada-webhook-cert                                  kubernetes.io/tls               3      2m50s
karmada-system   karmada-webhook-config                                Opaque                          1      2m46s
karmada-system   kube-controller-manager-ca-cert                       kubernetes.io/tls               2      2m48s
karmada-system   kube-controller-manager-config                        Opaque                          1      2m47s
karmada-system   kube-controller-manager-service-account-key-pair      Opaque                          2      2m48s
karmada-system   member1-kubeconfig                                    Opaque                          1      68s
karmada-system   member2-kubeconfig                                    Opaque                          1      63s
karmada-system   member3-kubeconfig                                    Opaque                          1      62s

@RainbowMango
Copy link
Member

Tested on MacOS?

@chaosi-zju
Copy link
Member Author

Tested on MacOS?

No, Karmada has not ever been successfully installed by local-up-karmada.sh on my macOS. so I can't test this PR on macOS.

Hi @hongshaoyang, can you please help check whether this PR can resolve your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envsubst: command not found on hack/deploy-karmada.sh on macOS
4 participants