Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the Karmada tutorial description #614

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shivansh-bhatnagar18
Copy link

What type of PR is this?

/kind documentation

What this PR does / why we need it
Initially, the resource migration documentation led to a misunderstanding that the nginx application-related resources are propagated to member2 but they are also propagated to member1

Which issue(s) this PR fixes:
Fixes #486

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 25, 2024
@karmada-bot karmada-bot requested review from Poor12 and Tingtal May 25, 2024 09:23
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 25, 2024
Signed-off-by: Shivansh Bhatnagar <[email protected]>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @chaosi-zju


```shell
$ kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml
kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml
$ kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml

This $ can be remained. Line 1 is command and line 2 is output.


```shell
kubectl --context member1 get deploy -o wide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl --context member1 get deploy -o wide
$ kubectl --context member1 get deploy -o wide

nginx-deploy 2/2 2 2 5m24s nginx nginx:latest app=nginx

kubectl --context member1 get svc -o wide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl --context member1 get svc -o wide
$ kubectl --context member1 get svc -o wide


```shell
kubectl --context member2 get deploy -o wide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl --context member2 get deploy -o wide
$ kubectl --context member2 get deploy -o wide

nginx-deploy 2/2 2 2 5m24s nginx nginx:latest app=nginx

kubectl --context member2 get svc -o wide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl --context member2 get svc -o wide
$ kubectl --context member2 get svc -o wide

```

This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application resources to both `member1` and `member2` clusters, meeting the desired propagation requirements.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application resources to both `member1` and `member2` clusters, meeting the desired propagation requirements.
This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application
resources to both `member1` and `member2` clusters, meeting the desired propagation requirements.

Wrapping long lines can make it prettier in the editing mode.

Comment on lines +183 to +184


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, why here added two empty line?

You should see the `nginx` application related resources originally in `member1` also propagated to `member2`, completing the migration of resources :
Copy link
Member

@chaosi-zju chaosi-zju Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and correcting the mistake here!

@chaosi-zju
Copy link
Member

I'm so sorry that I missed this PR. Do you still have time to fix the comment above? We will merge it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karmada tutorial description needs correction.
5 participants