-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the Karmada tutorial description #614
base: main
Are you sure you want to change the base?
Modified the Karmada tutorial description #614
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shivansh Bhatnagar <[email protected]>
Signed-off-by: Shivansh Bhatnagar <[email protected]>
8697ac6
to
c0e2471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @chaosi-zju
|
||
```shell | ||
$ kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml | ||
kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml | |
$ kubectl --context karmada-apiserver apply -f /tmp/pp-for-nginx-app.yaml |
This $
can be remained. Line 1 is command and line 2 is output.
|
||
```shell | ||
kubectl --context member1 get deploy -o wide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl --context member1 get deploy -o wide | |
$ kubectl --context member1 get deploy -o wide |
nginx-deploy 2/2 2 2 5m24s nginx nginx:latest app=nginx | ||
|
||
kubectl --context member1 get svc -o wide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl --context member1 get svc -o wide | |
$ kubectl --context member1 get svc -o wide |
|
||
```shell | ||
kubectl --context member2 get deploy -o wide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl --context member2 get deploy -o wide | |
$ kubectl --context member2 get deploy -o wide |
nginx-deploy 2/2 2 2 5m24s nginx nginx:latest app=nginx | ||
|
||
kubectl --context member2 get svc -o wide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl --context member2 get svc -o wide | |
$ kubectl --context member2 get svc -o wide |
``` | ||
|
||
This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application resources to both `member1` and `member2` clusters, meeting the desired propagation requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application resources to both `member1` and `member2` clusters, meeting the desired propagation requirements. | |
This confirms that the higher priority `PropagationPolicy` has effectively propagated the `nginx` application | |
resources to both `member1` and `member2` clusters, meeting the desired propagation requirements. |
Wrapping long lines can make it prettier in the editing mode.
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, why here added two empty line?
You should see the `nginx` application related resources originally in `member1` also propagated to `member2`, completing the migration of resources : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding and correcting the mistake here!
I'm so sorry that I missed this PR. Do you still have time to fix the comment above? We will merge it ASAP. |
What type of PR is this?
/kind documentation
What this PR does / why we need it
Initially, the resource migration documentation led to a misunderstanding that the
nginx
application-related resources are propagated tomember2
but they are also propagated tomember1
Which issue(s) this PR fixes:
Fixes #486