UTF-8 support #113
Open
UTF-8 support #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thank you for submitting this PR but I am hesitant to merge it to master in fear of breaking previous functionality etc, since it looks like a major change. However, if this was an entirely separate "uft8loader" class or something like that, with an option to use it instead of the default one that could be quite nice/useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support of UTF-8, must be compatible with models created from one-byte encoded inputs (but this is not verified), not compatible with old models created from utf-8 because they have sequences of bytes not multibyte characters ...
This PR slightly changes behaviour of file reader, now input processed line by line and if your input has no line delimiters and of big size then memory consumption can increase because such an input will be loaded in memory at once ...