Train status web interface #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karpathy any thoughts on this? |
|
What is the downside of having the JS code request an update vs streaming directly to client? Also, nice job. I had a hard time finding a way to use JSON since I'm less experienced with Lua, but you seemed to have solved the problem. |
|
Slight overhead - isn't noticeable amount though. It's just unnecessary to have a request & response rather than streaming responses after handshake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #82 and uses lua-websockets to have a websocket server running if
-visualizationflag is enabled (enabling also sets the port for which the server is to run). Instead of using files the initial data is sent when a connection is initiated, from there every time a client requests an update.. the info on page is updated.I was not able to obtain as clean of a solution as I would have liked due to cross-boundary c-code issues when copas yields, the downside of this is we currently must call update on client side prior to receiving the data (whereas I had hoped to stream it with no need to request past initial connection). Perhaps in future this can be solved but someone more knowledgeable.
All dependencies on js/css side are also now local, in case user is not connected to internet.
All settings were default other than gpu while testing, it would probably be smart to check with gpu enabled for a few minutes just in case any magical bugs sprout from the depths of hell.