clone needed #154
Open
clone needed #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A good test case for this is to try running a vanilla RNN with -seq_length 1. When I try those settings on Enwik8, the difference in loss is quite noticeable (i.e. higher than 4 without the fix, below 2 with the fix). |
SilverNexus
added a commit
to SilverNexus/mtg-rnn
that referenced
this pull request
Sep 7, 2019
Merge char-rnn pull request karpathy#154: clone needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think a clone_list is missing. It gives different results without it (even if it is probably insignificant).