Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned clone_many_times(net, T) #20

Closed
wants to merge 2 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2015

parametersNoGrad and net.parameters were not needed

`parametersNoGrad` and `net.parameters` were not needed
@karpathy
Copy link
Owner

Hmm I haven't gone through this function in too much detail. I assume you've tested this and there are no issues?

@ghost
Copy link
Author

ghost commented May 29, 2015

Yep my mistake, sorry about that, it worked fine on my code - mines a bit less complicated than yours? It should work with your repo now?

Why do you need net.parameters in your code - what is it?

I don't get why paramsNoGrad was there - it works fine with out it? That whole file could do with cleaning up?

I'm doing this PR because it confused me when I went through it, and I guess a lot of people will be using this code now?

There's been similar comments on other versions of this code - so I'm not the only one who was confused?

@ghost ghost closed this by deleting the head repository Oct 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant