don't run sf 3.4 and 4 with php8

karser · Dec 18, 2023 · 170c4f0 · 170c4f0
1 parent 692005a
commit 170c4f0
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 15 deletions.
diff --git a/.github/workflows/code_checks.yaml b/.github/workflows/code_checks.yaml
@@ -17,6 +17,18 @@ jobs:
         php: ['7.1', '7.2', '7.4', '8.0', '8.1', '8.2', '8.3']
         symfony: ['^3.4', '^4.0', '^5.0', '^6.0', '^7.0']
         exclude:
+          - symfony: ^3.4
+            php: 8.1
+          - symfony: ^3.4
+            php: 8.2
+          - symfony: ^3.4
+            php: 8.3
+          - symfony: ^4.0
+            php: 8.1
+          - symfony: ^4.0
+            php: 8.2
+          - symfony: ^4.0
+            php: 8.3
           - symfony: ^5.0
             php: 7.1
           - symfony: ^6.0
@@ -25,6 +37,8 @@ jobs:
             php: 7.2
           - symfony: ^6.0
             php: 7.4
+          - symfony: ^6.0
+            php: 8.3
           - symfony: ^7.0
             php: 7.1
           - symfony: ^7.0
@@ -35,17 +49,6 @@ jobs:
             php: 8.0
           - symfony: ^7.0
             php: 8.1
-        include:
-          - symfony: ^6.0
-            php: 8.0
-          - symfony: ^6.0
-            php: 8.1
-          - symfony: ^6.0
-            php: 8.2
-          - symfony: ^7.0
-            php: 8.2
-          - symfony: ^7.0
-            php: 8.3
       fail-fast: false
     name: PHPUnit (PHP ${{ matrix.php }}) (Symfony ${{ matrix.symfony }})
     steps:
@@ -81,16 +84,28 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.3
+          php-version: 7.4
           coverage: xdebug
 
+      - name: Get Composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Cache Composer
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.json **/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-php-${{ matrix.php }}-composer-
+
       - name: Install PHP dependencies
-        uses: ramsey/composer-install@v2
+        run: composer install --no-interaction
 
       - name: Run code coverage
         run: vendor/bin/phpunit --coverage-text --coverage-clover=coverage.clover

diff --git a/README.md b/README.md
@@ -32,7 +32,7 @@ Configuration without symfony/flex:
 
 ### 1. Register the bundle
 
-**Symfony 4/5/6 Version :**   
+**Symfony 4/5/6/7 Version :**   
 Register bundle into `config/bundles.php`:
 ```php 
 return [