Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow phpunit 10 #61

Merged
merged 3 commits into from
Jul 3, 2023
Merged

chore: allow phpunit 10 #61

merged 3 commits into from
Jul 3, 2023

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Apr 30, 2023

Update: After looking at the ci runs, there are some problem with older symfony versions.
Should be merged after support of the outdated versions is removed.

@karser
Copy link
Owner

karser commented May 5, 2023

Hi @Chris53897 , thank you for the PR.
I'd rather keep the outdated versions unless there is a strong reason.
Tests failed because composer installs phpunit 10 for symfony 3.4/4.4 and php > 8.
Can we add the failed php/symfony combinations to the exclude section?

@Chris53897
Copy link
Contributor Author

@karser Sorry for the delay. I found another solution. Just not allow phpunit 10 for older symfony versions.

@karser
Copy link
Owner

karser commented Jul 3, 2023

Thank you @Chris53897

@karser karser merged commit f2cc87e into karser:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants