Skip to content

Fix(curl): Prevent hang on successful empty response #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix(curl): Prevent hang on successful empty response #1012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion gptel-curl.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,11 @@ PROCESS and _STATUS are process parameters."
(when-let* ((reasoning (plist-get proc-info :reasoning))
((stringp reasoning)))
(funcall proc-callback (cons 'reasoning reasoning) proc-info))))
(when (or response (not (member http-status '("200" "100"))))
;; The original condition failed to call the callback when a request
;; succeeded (HTTP 200) but had an empty/malformed response body.
;; This new condition ensures the callback always fires for any completed
;; process, preventing a silent hang.
(when http-status
(with-demoted-errors "gptel callback error: %S"
(funcall proc-callback response proc-info))))
(gptel--fsm-transition fsm)) ;TYPE -> next
Expand Down