Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace highlight_lines with highlight_range with slightly improved result #72

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Replace highlight_lines with highlight_range with slightly improved result #72

merged 2 commits into from
Jul 20, 2022

Conversation

dhardy
Copy link
Contributor

@dhardy dhardy commented Jul 19, 2022

No description provided.

@dhardy
Copy link
Contributor Author

dhardy commented Jul 19, 2022

This is a partial fix for kas-gui/kas#232.

@dhardy
Copy link
Contributor Author

dhardy commented Jul 20, 2022

Really, the highlight_line method wants improving too. Ideas:

  • Possibly sorting runs into visual order
  • Attempting to merge runs where they are visually contiguous (non-trivial for tabs and justified alignment where the run blocks don't physically touch)
  • Possibly for this purpose RunPart should contain more data

@dhardy dhardy merged commit 2eeebe1 into master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dhardy