Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset of #387 #389

Merged
merged 19 commits into from
Jun 9, 2023
Merged

Subset of #387 #389

merged 19 commits into from
Jun 9, 2023

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Jun 8, 2023

This comprises the less contentious/involved subset of #387 plus a few extras. I didn't want to split the PR like this because it's more work, but the new trait model is still not done and the PR is too large.

  • Remove Debug bound on widgets
  • Remove MapMessage
  • Slider, Spinner have default step size
  • Move fns make_id, reconstruct_key to trait DataKey
  • Rename request_configure to request_reconfigure, fix bugs, do not use for new elements added to containers (List, etc.)
  • Rename request_update to request_timer_update
  • EditField: set selection on focus; change behaviour of left/right arrow keys given a selection without shift key pressed
  • Add Command::Debug to print widget heirarchy to log on F8 (eventually this key-binding will need to be changed)
  • Add Splitter::extend, resize_with
  • Add Event::is_reusable, remove Widget::handle_unused, call handle_event instead but only for reusable events
  • Add Event::CursorMove for motion without a grab press (mostly because CursorMove is reusable while PressMove is not)

@dhardy dhardy changed the title Work1 Subset of #387 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant