Subset of #387 #389
Merged
Subset of #387 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice this is not useful.
This is barely used as-is, and synchronised widgets will in future use input data, not embedded shared state.
…c6a77e We don't have a good reason not to immediately configure and delayed configure must re-configure parent (and all other children).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comprises the less contentious/involved subset of #387 plus a few extras. I didn't want to split the PR like this because it's more work, but the new trait model is still not done and the PR is too large.
Debugbound on widgetsMapMessageSlider,Spinnerhave default step sizemake_id,reconstruct_keyto traitDataKeyrequest_configuretorequest_reconfigure, fix bugs, do not use for new elements added to containers (List, etc.)request_updatetorequest_timer_updateEditField: set selection on focus; change behaviour of left/right arrow keys given a selection without shift key pressedCommand::Debugto print widget heirarchy to log on F8 (eventually this key-binding will need to be changed)Splitter::extend,resize_withEvent::is_reusable, removeWidget::handle_unused, callhandle_eventinstead but only for reusable eventsEvent::CursorMovefor motion without a grab press (mostly becauseCursorMoveis reusable whilePressMoveis not)