Events::recurse_range, kas_core::Popup, EventState::depress_with_key #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change anything except that _nav_next is now the only reason a direct impl of Widget is required.
Also fix Up/Down keys on menus
This removes some automatic closures of popups.
This is unused and likely not useful once translation is enabled
This is more standard terminology (also: mnemonic key).
This fixes button depress in the calculator, also depressing tabs and spinner mark-buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Events::recurse_rangeand use to restrict bothconfigureandupdateto (a superset of) visible widgets. As a consequence, hidden widgets may not have aWidgetIdassigned, which required a change in the gallery but otherwise appears fine. This could be changed if required.Add
kas_core::Popupwidget as the root of all popups (similar to theWindowwidget). This avoids redundant logic inComboBoxandSubMenuand fixes some things in the gallery's popup. Several more fixes related to popups included (including the annoying mouse focus issue in the gallery's pop-up edit-box).Rename "accelerator keys" to "access keys" which is a more standard name (the other being mnemonics).
Add
EventState::depress_with_key; widgets are now call this explicitly to depress themselves as a result of key-activation. This fixes button-depression on key usage in the calculator and adds it forTabwidgets andSpinnerup/down buttons (those need better visuals now).