Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove return values on some closures; replace some custom widgets #432

Merged
merged 5 commits into from
Dec 23, 2023

Conversation

dhardy
Copy link
Collaborator

@dhardy dhardy commented Dec 21, 2023

fn AppData::handle_messages previously returned Action, however:

  • The only sensible return values are Action::empty() and Action::UPDATE, hence we could replace with bool
  • Assuming UPDATE when any message was removed from the stack is a good enough approximation, hence we don't need a return value at all

Similarly, Adapt's message and timer handlers can also get away without using any return values (on the assumption that a timer is only requested when it is likely that something will happen, and that Adapt only makes things happen by adjusting its state; these appear reasonable assumptions given the intended usages).

Also, replace a couple more instances of custom widgets in examples.

Also increase the default font size to 16px (12pt).

@dhardy dhardy merged commit 96b828f into master Dec 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant