MSRV=1.75: RPITIT; fixes #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove "start = 0" variants of iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to reduce resize/set_size in
examples/data-list-view.rs.Bump MSRV to 1.75 and make use of RPITIT.
Note: it is possible to also use RPITIT for
SharedData::borrow, but since there is (currently) no mechanism to refer to the return type, it is impossible to specify (refine) thatUnsafeFilteredList::borrowreturns the sameItemReftype as the innerSharedData. This causes some minor issues due to the looser lifetime specification. Further,SharedData::borrowcarries useful documentation. It also does not appear to simplify implementations much. It is therefore decided not to use RPITIT here.