Skip to content

Conversation

@LaurenSamuels
Copy link

Hi- thank you so much for this package. I added rounding in one line; you might also want to modify the line for cum.n.censor the same way.

.DS_Store
docs/.DS_Store
inst/doc
*.swp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be not needed....

Copy link

@MaverickMeerkat MaverickMeerkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git ignore change is probably a mistake. Could you please undo it?
Also you added a binary file which not sure if needed.
Maybe this is what preventing this important pull request from being approved...

@LaurenSamuels
Copy link
Author

@MaverickMeerkat , Thank you for taking a look at this. I agree that the gitignore change should not be included, but I am having trouble undoing it. Would you be able to either spell out exactly what I need to do, or just add the one useful line to .get_timepoints_survsummary another way?

1 similar comment
@LaurenSamuels
Copy link
Author

@MaverickMeerkat , Thank you for taking a look at this. I agree that the gitignore change should not be included, but I am having trouble undoing it. Would you be able to either spell out exactly what I need to do, or just add the one useful line to .get_timepoints_survsummary another way?

@MaverickMeerkat
Copy link

I opened a new pull request, because otherwise I think you would have needed to grant me permissions to change your own PR. It's here: #564

@LaurenSamuels
Copy link
Author

Closing this request, because @MaverickMeerkat has submitted a better one (many thanks!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants