Fix ggplot2 development version compatibility #681 #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove manual class assignment in theme_survminer() to ensure proper theme object construction compatible with ggplot2 development version.
Update test to use @layers syntax for ggplot2 > 3.5.2, maintaining backward compatibility with $layers for older versions.
Document ggplot2 compatibility fixes and add version comparison utility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
theme_survminer()Changes
class(result) <- "theme"to use proper ggplot2 theme construction@layersfor ggplot2 > 3.5.2,$layersfor older versionsis_pkg_version_sup()utility for version checkingTest Results
All tests pass with ggplot2 development version. Theme validation warnings eliminated.
Closes #681