-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repository): Metadata compression config support for indirect content #557
feat(repository): Metadata compression config support for indirect content #557
Conversation
bb7e7bd
to
b29e3a5
Compare
Signed-off-by: Prasad Ghangal <[email protected]>
Signed-off-by: Prasad Ghangal <[email protected]>
01b1766
to
1eb6816
Compare
Signed-off-by: Prasad Ghangal <[email protected]>
25d4fb5
to
a11a23b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, from first look I don't see any showstoppers. But I'd wait for second pair of eyes, to have greater confidence.
Also I see that tests are failing, not sure why (have not checked, might be needed to update tests).
Signed-off-by: Prasad Ghangal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for moving the compression parameter to constructor.
…559) Related to #557 and #556 --------- Signed-off-by: Prasad Ghangal <[email protected]>
b03d9e7
into
md-compression-setting-k-content
Overview:
This PR is based on #556
This PR adds support to set compression algorithm for indirectContent type of metadata (metadata with
x
prefix)Test plan
zstd-fastest
repo
dir and observe stats. Validate content withx
prefix is compressed withzstd-fastest
s2-default
s2-default
tests
dirtests
dir and inspect content. New metadata stats should be seen asuncompressed