Pass context to kube.Exec and similar functions. #25703 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go version bumped due to Kanister requirements. |
|
TMP commit refers proper Kanister revision. Should be removed before merging. PR should be merged only after Kanister one will be merged. |
e-sumin
force-pushed
the
pass-context-to-kube-exec
branch
2 times, most recently
from
d631721 to
67b1aa0
Compare
hairyhum
approved these changes
May 31, 2024
bathina2
approved these changes
Jun 3, 2024
e-sumin
force-pushed
the
pass-context-to-kube-exec
branch
from
67b1aa0 to
9b1188f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, commands executed in pods are not aware of context state, and if context is cancelled they are still running.
This PR changes K10 code so that context is always passed to any kind of kube.Exec method.
There is related Kanister PR kanisterio/kanister#2878 which contains passing context right to the Kubernetes Executor.StreamWithContext which states "The context controls the entire lifetime of stream execution."