Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming "./kubestr browse" command to "./kubestr browse pvc" #275

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

shlokc9
Copy link
Contributor

@shlokc9 shlokc9 commented Jul 24, 2024

This PR renames the ./kubestr browse command to ./kubestr browse pvc while maintaining the support for ./kubestr browse.

Tested these code changes by executing both the commands on a GKE cluster. Please find the output below;

> ./kubestr browse pvc test-pvc1 -n file-level-restore -v test-snapshotclass
Taking a snapshot
Creating the file browser application.
Forwarding the port.
Port forwarding is ready to get traffic. visit http://localhost:8080/
^CStopping port forward
Cleaning up resources
> ./kubestr browse test-pvc1 -n file-level-restore -v test-snapshotclass
Taking a snapshot
Creating the file browser application.
Forwarding the port.
Port forwarding is ready to get traffic. visit http://localhost:8080/
^CStopping port forward
Cleaning up resources

During cleanup, we clean the placeholder VolumeSnapshot, PVC created from that VolumeSnapshot & the Filebrowser pod.

@shlokc9 shlokc9 added enhancement New feature or request CS Browse feature go Pull requests that update Go code labels Jul 24, 2024
@shlokc9 shlokc9 requested review from bathina2 and kidgilson July 24, 2024 19:58
@shlokc9 shlokc9 self-assigned this Jul 24, 2024
@shlokc9 shlokc9 linked an issue Jul 24, 2024 that may be closed by this pull request
cmd/rootCmd.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bathina2 bathina2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits about messaging

cmd/rootCmd.go Outdated Show resolved Hide resolved
@bathina2 bathina2 self-requested a review July 30, 2024 20:42
@shlokc9 shlokc9 merged commit 68d1954 into kastenhq:master Jul 31, 2024
4 checks passed
@shlokc9 shlokc9 deleted the update-browse-pvc branch July 31, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CS Browse feature enhancement New feature or request go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

Adding new capabilities to the "./kubestr browse" command
2 participants