Quick fix for bug #79 #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe not the most ideal way to fix this, but it does prevent the 'single' checkbox type from subscribing people who didn't opt in. Does not affect the other types, although the dropdown select never did work due to a different bug. A better way to fix this might be to add 'ctctcf7_lists' to the 'Opt-In Field' dropdown list on the Constant Contact tab, but I haven't yet found where to add that - maybe something the plugin author can address more adequately.
This might cause a conflict with the dropdown lists once that bug is fixed, but this test isn't working and I'm not certain why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe not the most ideal way to fix this, but it does prevent the
'single' checkbox type from subscribing people who didn't opt in. Does
not affect the other types, although the dropdown select never did work
due to a different bug. A better way to fix this might be to add
'ctctcf7_lists' to the 'Opt-In Field' dropdown list on the Constant
Contact tab, but I haven't yet found where to add that - maybe something
the plugin author can address more adequately.