Skip to content

Conversation

@kaukabrizvi
Copy link
Owner

PR Description

This PR adds an optional prefix-symbols feature to boring and boring-sys that prefixes all BoringSSL libssl/libcrypto symbols to avoid collisions with OpenSSL or other BoringSSL variants.

What this does

  • Adds a prefix-symbols Cargo feature.

  • Unix-only build logic that:

    • Uses nm to list global symbols.
    • Applies prefixes via objcopy --redefine-syms.
    • Updates bindgen link names through a custom ParseCallbacks.

Why

This enables BoringSSL to safely coexist with OpenSSL build inside the same process - necessary for interoperability testing with s2n-tls

Can't build with clang-12 to libc++ mismatch
@kaukabrizvi kaukabrizvi requested a review from jmayclin December 22, 2025 21:11
@kaukabrizvi
Copy link
Owner Author

kaukabrizvi commented Dec 22, 2025

Once this is approved+merged, I’ll update aws/s2n-tls#5659 to pull from main instead of this branch. main keeps the fork up to date via https://wei.github.io/pull/

@kaukabrizvi kaukabrizvi merged commit f7296d9 into master Dec 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants