fix(grpc): honor RPC status, timeout settings and reflection headers - #34
Open
rupayon123 wants to merge 4 commits into
Open
rupayon123 wants to merge 4 commits into
rupayon123 wants to merge 4 commits into
Conversation
rupayon123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
The gRPC client printed server errors while returning success, omitted headers from authenticated reflection, and did not consistently honor timeout settings. Return non-OK status errors, send metadata to reflection, apply positive timeouts to the complete call and let timeout 0 disable the added deadline while honoring the caller context. Four local-server regression groups reproduce and cover these behaviors.
Validation
The new regression groups failed before their corresponding fixes. Full
env -u NO_COLOR go test ./...,go vet ./..., formatting and diff checks pass. Remote build passes on3b2902fd97a0b89ada5f9a45d1e211e324c4c719.golangci-lintis unavailable locally. Prepared with AI assistance.