fix(response): preserve body bytes and separate verbose exchanges - #35
Open
rupayon123 wants to merge 4 commits into
Open
rupayon123 wants to merge 4 commits into
rupayon123 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Preserve raw response whitespace and CRLF, reject JSON/prose as invalid header names, and retain only the final exchange when parsing verbose redirects or interim responses. Recognize request-line structure so HTTP-like header values do not reset it. Preserve whitespace-only bodies through FromHTTPResponse and retain empty-body warnings only for genuinely empty content. Regression tests cover both parsing entry points, valid token header names, redirects and 103 Early Hints.
Validation
The new regression groups failed before their corresponding fixes. Full
env -u NO_COLOR go test ./...,go vet ./..., formatting and diff checks pass. Remote build passes on15a272ca81f6858622899c2cf8d8a0d8e5f1881e.golangci-lintis unavailable locally. Prepared with AI assistance.