Added a transfer record endpoint for querying the journal. #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-cohere
added
enhancement
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 23 23
Lines 2175 2175
=======================================
Hits 1458 1458
Misses 574 574
Partials 143 143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeff-cohere
commented
Oct 31, 2025
|
|
||
| records, err := journal.Records(input.Start, input.End) | ||
| if err != nil { | ||
| return nil, huma.Error404NotFound(err.Error()) |
There was a problem hiding this comment.
A 404 error here is a bit presumptuous, so maybe this could be fleshed out with all the relevant possibilities in a type switch statement.
mattldawson
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
transfer/recordsendpoint that allows for the querying of completed transfers bookended by two timestamps. The logic is simple, but devising a test for it can take some care.In advance of devising a unit test for this endpoing (in part because we're reworking a lot of unit tests at the moment), I wanted to put this up and try to test it this weekend when I'm testing the new transfer orchestration code in NERSC's Spin environment.