Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.2 release (develop -> master) #89

Merged
merged 40 commits into from
Nov 22, 2024
Merged

1.0.2 release (develop -> master) #89

merged 40 commits into from
Nov 22, 2024

Conversation

Xiangs18
Copy link
Collaborator

No description provided.

Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look reasonable based on spot checks other than a possible version skip

RELEASE_NOTES.md Outdated
Comment on lines 3 to 11
### Version 1.0.3
* The MongoDB clients have been updated to the most recent version.
* Added the mongo-retrywrites configuration setting in deployment.cfg.templ, defaulting to false.
* Migrated from Travis CI to GitHub Actions workflows.
* Updated Python version to 3.9.19.

### Version 1.0.2
- Add a cache for bad tokens so they aren't looked up over and over. Maxes out at 10000, then throws out the oldest bad token.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briehl it looks like 1.0.2 was never released, can you confirm? If so we should merge the 1.0.3 changes into 1.0.2

Copy link
Collaborator Author

@Xiangs18 Xiangs18 Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rolled back and checked in CI:

{"gitcommithash":"a2ed4cb88120aeb10a295919cb0fba85e13d462d","servertime":1732243387039,"service":"Notification Feeds Service","version":"1.0.2"}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't mean it was released

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm 1.0.2 was never released in production. Not sure why.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#90

@Xiangs18 Xiangs18 requested a review from MrCreosote November 22, 2024 21:34
@Xiangs18 Xiangs18 changed the title 1.0.3 release (develop -> master) 1.0.2 release (develop -> master) Nov 22, 2024
@Xiangs18 Xiangs18 merged commit 8c5072a into main Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants