Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-419 WIP: Migrate narrative-traefiker to using classes instead of modules for orchestration handlers #105

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

sychan
Copy link
Contributor

@sychan sychan commented Aug 31, 2021

This is a WIP feature branch that replaces the original Python module based method of "pluggable" orchestration support with a class based model. It is a work in progress and needs some additional work:

  • Add a base class that has the signature/interface that needs to be implemented
  • Fully migrate the app.py code so that it just uses an instance variable for the orchestration object, instead of a bunch of method pointers
  • Test the code in Next to ensure that it all still works as before
  • Add some basic tests (somewhat problematic since it requires a running Rancher instance and traefik, though it could be done)

app.py Show resolved Hide resolved
@bio-boris bio-boris changed the title WIP: Migrate narrative-traefiker to using classes instead of modules for orchestration handlers DEVOPS-419 WIP: Migrate narrative-traefiker to using classes instead of modules for orchestration handlers Sep 14, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request fixes 13 alerts when merging 7c0b979 into a4e1243 - view on LGTM.com

fixed alerts:

  • 13 for Clear-text logging of sensitive information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants