DATAUP-765: assertify tests #3389
Conversation
ialarmedalien
changed the base branch from
develop
to
DATAUP-765_add_wsid_to_job
| @@ -1,14 +1,27 @@ | |||
| import copy | |||
| from typing import Any | |||
There was a problem hiding this comment.
added in typing and method descriptions to help me whilst I was converting the tests.
| lines.append( | ||
| {"is_error": 0, "line": "This is line {}".format(i + skip)} | ||
| ) | ||
| lines.append({"is_error": 0, "line": f"This is line {i + skip}"}) |
There was a problem hiding this comment.
use f-string
| @@ -74,7 +72,7 @@ def set_ws_name(ws_name): | |||
| ] | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("result,path,expected", get_result_sub_path_cases) | |||
| @pytest.mark.parametrize(("result", "path", "expected"), get_result_sub_path_cases) | |||
There was a problem hiding this comment.
Ruff prefers tuples to comma-separated strings, obviously!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3389 +/- ##
===========================================
- Coverage 29.35% 29.33% -0.02%
===========================================
Files 497 497
Lines 50569 50567 -2
===========================================
- Hits 14843 14836 -7
- Misses 35726 35731 +5
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ialarmedalien
force-pushed
the
DATAUP-765_assertify
branch
from
2f54786 to
22d6cea
Compare
ialarmedalien
force-pushed
the
DATAUP-765_add_wsid_to_job
branch
from
4faae24 to
b982e48
Compare
| @@ -48,26 +48,32 @@ define([ | |||
| this._super(options); | |||
There was a problem hiding this comment.
These changes are back! 😱
Was that intentional this time?
There was a problem hiding this comment.
Nope! Grrrrrr...
Removing some comments and an extraneous method; general tidying
ialarmedalien
force-pushed
the
DATAUP-765_assertify
branch
from
12bc8bf to
9c2ec3d
Compare
|
Description of PR purpose/changes
Convert existing
self.assert...style-tests to the pytest-friendlyassertversions.Basically a big search-and-replace, aided by Ruff's auto-fix feature.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/DATAUP-765
DATAUP-69 Adds a PR template)Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)