Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-41 update jupyter notebook to 6.5.6 #3453

Closed
wants to merge 3 commits into from

Conversation

briehl
Copy link
Member

@briehl briehl commented Apr 5, 2024

Description of PR purpose/changes

There are numerous issues with the build right now. The latest is getting the most recent Jupyter notebook (version 6.x) installed, and meshing that with our extensions. They've removed jquery-ui, which KBase uses for a few older widgets, and moved an empty, but expected, file to a new location. The easiest fix there is to just drop a new file in place to keep the Notebook engine happy.

Jira Ticket / Issue

Related Jira ticket: https://kbase-jira.atlassian.net/browse/UIP-41

  • Added the Jira Ticket to the title of the PR (e.g. DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
  • Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • (JavaScript) I have run Prettier and ESLint on changed code manually or with a git precommit hook
  • [n/a] (Python) I have run Black and Flake8 on changed Python code manually or with a git precommit hook
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@@ -36,14 +38,13 @@ This is built on the Jupyter Notebook v6.4.12 and IPython 8.5.0 (more notes will
- @wdio/browserstack-service: 8.12.2 -> 8.29.3
- @wdio/cli: 8.12.2 -> 8.29.3
- axios: 1.4.0 -> 1.6.1
- chromedriver: 114.0.2 -> 121.0.0
- chromedriver: 114.0.2 -> 123.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this an error in a previous update?

@briehl
Copy link
Member Author

briehl commented Apr 8, 2024

Pulling from wrong fork!

@briehl briehl closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants