Fix semicolon error masking #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ialarmedalien
commented
Apr 22, 2024
| @@ -46,7 +46,8 @@ RUN \ | |||
| /bin/bash scripts/install_narrative_docker.sh && \ | |||
| cd /tmp && \ | |||
| mkdir /tmp/narrative && \ | |||
| chown -R nobody:www-data /tmp/narrative /kb/dev_container/narrative ; find / -xdev \( -perm -4000 \) -type f -print -exec rm {} \; | |||
| chown -R nobody:www-data /tmp/narrative /kb/dev_container/narrative && \ | |||
There was a problem hiding this comment.
With a semicolon, the find command would execute regardless of whether any of the previous steps errored out, so it was possible to create a narrative image where none of the JS or Python stuff was installed. 😱
briehl
approved these changes
Apr 22, 2024
| @@ -46,7 +46,8 @@ RUN \ | |||
| /bin/bash scripts/install_narrative_docker.sh && \ | |||
| cd /tmp && \ | |||
| mkdir /tmp/narrative && \ | |||
| chown -R nobody:www-data /tmp/narrative /kb/dev_container/narrative ; find / -xdev \( -perm -4000 \) -type f -print -exec rm {} \; | |||
| chown -R nobody:www-data /tmp/narrative /kb/dev_container/narrative && \ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
A misplaced semicolon in some shell script in the Dockerfile was masking errors that might have occurred in commands earlier in the script.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/DATAUP-X
DATAUP-69 Adds a PR template)Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)