UIP-44 Convert DIE download URL to Blobstore #3595
Conversation
| shockURL: Config.url('shock'), | ||
| exportURL: Config.url('data_import_export'), | ||
| nmsURL: Config.url('narrative_method_store'), |
There was a problem hiding this comment.
shock and export URLs are no longer used.
NMS URL is only used once to make a client, didn't seem worth keeping in the widget's memory.
(eeURL gets reused several times)
|
| @@ -187,10 +184,10 @@ define([ | |||
| app_id: method, | |||
| }, | |||
| ]) | |||
| ).then(([jobId]) => [jobId, wsObjectName]); | |||
There was a problem hiding this comment.
No longer pass around the object name to different things. Previously, it was only injected into the download URL, blobstore doesn't do that.
| @@ -2,6 +2,7 @@ | |||
| "appdev": { | |||
| "auth": "https://appdev.kbase.us/services/auth", | |||
| "awe": "https://appdev.kbase.us/services/awe-api", | |||
| "blobstore": "https://appdev.kbase.us/services/blobstore", | |||
There was a problem hiding this comment.
New URL!
I don't really like this format, but not worth changing around in this PR. There's a ticket out there.
| @@ -204,7 +204,7 @@ define([ | |||
| const iframe = document.getElementById('hiddenDownloader'); | |||
| expect(iframe).not.toBeNull(); | |||
| const expectedUrl = | |||
| 'https://ci.kbase.us/services/data_import_export/download?id=some_shock_id&del=1&name=fake_test_object.SOME_FORMAT.zip&url=https%3A%2F%2Fci.kbase.us%2Fservices%2Fshock-api'; | |||
| 'https://ci.kbase.us/services/blobstore/node/some_shock_id?download&del'; | |||
There was a problem hiding this comment.
It's easy to alter tests once we have them...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3595 +/- ##
===========================================
- Coverage 25.90% 0.00% -25.91%
===========================================
Files 461 461
Lines 46646 46643 -3
===========================================
- Hits 12084 0 -12084
- Misses 34562 46643 +12081
... and 327 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description of PR purpose/changes
As it says. Out with the old, in with the new.
Also removes refs to unused variables and the DIE url from the download panel, and a few minor things mentioned inline.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/UIP-44
DATAUP-69 Adds a PR template)Testing Instructions
Dev Checklist:
formatandcheckon changed Python code manually or with a git precommit hookUpdating Version and Release Notes (if applicable)