Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URO-352 DTS importer setup for narrative #3677

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

briehl
Copy link
Member

@briehl briehl commented Dec 18, 2024

NO TESTS YET. DO NOT MERGE.

Just putting this up here to get an image up on CI for testing.

Description of PR purpose/changes

The Data Transfer Service moves batches of files from one system to another. In the first usage, it'll move from IMG to KBase and dump the files in the user's staging area. It also drops of a manifest file that will have instructions on how to do the importing.

The staging services (in CI) is updated to know how to deal with those files as bulk import specs. This change modifies the front end to do the same. It does this in a few ways.

  1. Add the DTS manifest as an option for import
  2. For those files selected that way, make sure to add the dts flag to the bulk import spec GET request
  3. Also change the client to support adding a flag like that
  4. Refactor the importer code to shuffle those together with other bulk import into a single bulk import cell, as appropriate.

Jira Ticket / Issue

Related Jira ticket: https://kbase-jira.atlassian.net/browse/URO-352

  • Added the Jira Ticket to the title of the PR (e.g. DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
  • Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • (JavaScript) I have run Prettier and ESLint on changed code manually or with a git precommit hook
  • (Python) I have run Ruff format and check on changed Python code manually or with a git precommit hook
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 25.90%. Comparing base (90ed107) to head (012e5ac).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...se/js/widgets/narrative_core/upload/importSetup.js 93.93% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3677   +/-   ##
========================================
  Coverage    25.90%   25.90%           
========================================
  Files          461      461           
  Lines        46653    46660    +7     
========================================
+ Hits         12085    12088    +3     
- Misses       34568    34572    +4     
Files with missing lines Coverage Δ
...ension/static/kbase/js/api/StagingServiceClient.js 100.00% <ø> (ø)
...se/js/widgets/narrative_core/upload/importSetup.js 91.24% <93.93%> (-6.46%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b168c...012e5ac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant