Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA tests, update GHA, simplify tests, remove cruft #90

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

MrCreosote
Copy link
Member

Should no longer need submodules, will remove later

  • Jars are now expected to be a sister folder (which will be removed with the Gradle conversion
  • module_builder seems to only be used in test/data/test_repo_1/service/init.sh which is not called from anywhere, and deleting it doesn't cause the tests to fail

Should no longer need submodules, will remove later
* Jars are now expected to be a sister folder (which will be removed
with the Gradle conversion
* module_builder seems to only be used in
`test/data/test_repo_1/service/init.sh` which is not called from
anywhere, and deleting it doesn't cause the tests to fail
@MrCreosote MrCreosote requested a review from Xiangs18 April 17, 2024 03:46
Just makes the image build - haven't tested that the server works, will
do that later
@MrCreosote MrCreosote changed the base branch from master to develop April 17, 2024 23:54
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Collaborator

@Xiangs18 Xiangs18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrCreosote MrCreosote merged commit 39c89e1 into develop Apr 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants