Skip to content

Commit

Permalink
Remove a few TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
jayrbolton committed Aug 19, 2020
1 parent 090b6b0 commit 45df955
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions src/search1_conversion/convert_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
used to create the object and their version and version control
commit hash. Not all keys may be present; if not their values were
not available in the search data.
highlight - dict of string to list of string - search result highlights from ES. TODO
highlight - dict of string to list of string - search result highlights from ES
The keys are the field names and the list contains the sections in
each field that matched the search query. Fields with no hits will
not be available. Short fields that matched are shown in their
Expand Down Expand Up @@ -151,7 +151,6 @@ def _get_search_params(params):
query['bool']['must'] = query['bool'].get('must', [])
query['bool']['must'].append({'range': {'timestamp': {'gte': min_ts, 'lte': max_ts}}})
else:
# TODO proper error
raise ResponseError(code=-32602, message="Invalid timestamp range in match_filter/timestamp")
# Handle a search on tags, which corresponds to the generic `tags` field in all indexes.
if match_filter.get('source_tags'):
Expand Down
1 change: 0 additions & 1 deletion src/search2_rpc/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ def show_indexes(params, meta):
headers={'Content-Type': 'application/json'},
)
if not resp.ok:
# TODO better error class
raise ElasticsearchError(resp.text)
resp_json = resp.json()
result = []
Expand Down

0 comments on commit 45df955

Please sign in to comment.