DATAUP-223 Change POST to get, update mappings #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bio-boris
commented
Nov 13, 2020
•
bio-boris
commented
- Change post to get
- Use a querystring
- Update mappings
- Change ID to map to narrative config
- UPdate tests that broke
bio-boris
commented
Nov 18, 2020
bio-boris
changed the title
added 2 commits
November 18, 2020 14:25
MrCreosote
reviewed
Nov 19, 2020
|
Looks like there's this comment that is unaddressed, maybe you missed it in the deluge? |
|
Looks like the tests are failing and codacy is unhappy again |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.