Add MFA status indicators to login sessions #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add mfaAuthenticated field to token type definitions - Create MfaStatusIndicator component with color-coded icons - Add MFA Status column to both Current and Other login session tables - Display green check (MFA used), red check (single factor), or grey check (not supported) - Include tooltips for each status type - Only show indicators for Login token types
| <FontAwesomeIcon icon={faCheck} style={{ color: 'green' }} /> | ||
| </Tooltip> | ||
| ); | ||
| } else if (mfaAuthenticated === false) { |
There was a problem hiding this comment.
no need to use else if the previous statement was a return
| <FontAwesomeIcon icon={faCheck} style={{ color: 'red' }} /> | ||
| </Tooltip> | ||
| ); | ||
| } else { |
| <FontAwesomeIcon icon={faCheck} style={{ color: 'green' }} /> | ||
| </Tooltip> | ||
| ); | ||
| } else if (mfa === 'NOT_USED') { |
There was a problem hiding this comment.
no need for else after a return
https://eslint.org/docs/latest/rules/no-else-return
why I started following this rule:
There was a problem hiding this comment.
I feel it makes it less readable... else makes it clear it's exclusive to the blocks above, especially for multiple if-else-ifs
There was a problem hiding this comment.
ie I agree it is "textually" (in execution) superfluous but I think it is sub-textually substantial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new auth2 mfa feature kbase/auth2#471. Should only be merged and deployed after auth2#471 is merged and deployed in all environments.