Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: better go module import impl #373

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #332
re kcl-lang/kcl#1543

refactor: better go module import impl

@Peefy Peefy force-pushed the better-go-mod-import-devex branch from 0b41f99 to 4ff2c0f Compare August 19, 2024 14:37
@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10465566577

Details

  • 154 of 192 (80.21%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 32.767%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/gen/genkcl_gostruct.go 154 192 80.21%
Files with Coverage Reduction New Missed Lines %
pkg/tools/gen/genkcl_gostruct.go 1 80.61%
Totals Coverage Status
Change from base Build 10453927592: 0.5%
Covered Lines: 5746
Relevant Lines: 17536

💛 - Coveralls

@Peefy Peefy force-pushed the better-go-mod-import-devex branch from 4ff2c0f to e627d14 Compare August 20, 2024 05:02
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e13a75e into kcl-lang:main Aug 20, 2024
11 checks passed
@Peefy Peefy deleted the better-go-mod-import-devex branch August 20, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support Go API for GetSchemaTypeMapping
3 participants