ci: add GitHub Actions workflow + arbitrum blob-fee test - #28
Closed
Pattermesh wants to merge 2 commits into
Closed
Pattermesh wants to merge 2 commits into
Pattermesh wants to merge 2 commits into
Conversation
Add a CI workflow (install + test on push/PR to main) and one test covering the arbitrum adapter's blob-base-fee -> L1 data-fee component of the predicted L2 gas cost, which was previously untested. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Welcome to kcolbchain, @Pattermesh — glad you're here. 🌱 Here's what happens from this PR:
While you wait:
What happens after your first merge
Thanks for writing the code. We're building this to last. |
Contributor
|
This issue/PR has had no activity for 21 days and is being closed automatically by the kcolbchain PR pipeline. If it's still relevant, reopen or leave a comment and we'll re-triage. For the full policy see pipeline docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yml) that runsnpm install+npm teston pushes and PRs tomain. The repo had test files but no CI.tests/chains/arbitrum.test.ts) for the Arbitrum adapter's blob-fee logic: it verifies thatcomputeL2Costderives the L1 data-fee component from the blob base fee (blobBaseFee * 1600 / 16), adds it on top of the L2 execution fee, scales linearly with the blob fee, and reduces to the bare execution fee at zero blob fee. This adapter was the core piece of blob-fee -> L2 gas-cost logic that had no test coverage (scroll/blast/zksync/mantle/polygonzkevm already had tests).Test output
(38 -> 43 tests; the new file adds 5.)
Notes
CI runs
npm testonly.npm run lintcurrently fails on a pre-existing duplicate shebang insrc/cli.tsunrelated to this change, so it is intentionally left out of CI to keep this PR small and CI green.🤖 Generated with Claude Code