Skip to content

ci: add GitHub Actions workflow + arbitrum blob-fee test - #28

Closed
Pattermesh wants to merge 2 commits into
mainfrom
pattermesh/gas-oracle-ci-test
Closed

Pattermesh wants to merge 2 commits into
mainfrom
pattermesh/gas-oracle-ci-test

Conversation

@Pattermesh

Copy link
Copy Markdown

Summary

  • Add a GitHub Actions CI workflow (.github/workflows/ci.yml) that runs npm install + npm test on pushes and PRs to main. The repo had test files but no CI.
  • Add one meaningful test (tests/chains/arbitrum.test.ts) for the Arbitrum adapter's blob-fee logic: it verifies that computeL2Cost derives the L1 data-fee component from the blob base fee (blobBaseFee * 1600 / 16), adds it on top of the L2 execution fee, scales linearly with the blob fee, and reduces to the bare execution fee at zero blob fee. This adapter was the core piece of blob-fee -> L2 gas-cost logic that had no test coverage (scroll/blast/zksync/mantle/polygonzkevm already had tests).

Test output

 Test Files  7 passed (7)
      Tests  43 passed (43)

(38 -> 43 tests; the new file adds 5.)

Notes

CI runs npm test only. npm run lint currently fails on a pre-existing duplicate shebang in src/cli.ts unrelated to this change, so it is intentionally left out of CI to keep this PR small and CI green.

🤖 Generated with Claude Code

Add a CI workflow (install + test on push/PR to main) and one test
covering the arbitrum adapter's blob-base-fee -> L1 data-fee component
of the predicted L2 gas cost, which was previously untested.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@abhicris

Copy link
Copy Markdown
Contributor

Welcome to kcolbchain, @Pattermesh — glad you're here. 🌱

Here's what happens from this PR:

  1. Our automated review looks for obvious issues (tests, secrets, size) within a couple of hours.
  2. If it's clean and CI passes, we merge without back-and-forth.
  3. If we need changes, we'll leave a specific comment — not a generic nit. Push another commit and we re-review.

While you wait:

  • Run the repo's tests locally (see the repo README.md).
  • Keep the PR scoped to one concern — bigger PRs land slower.
  • Don't commit tokens or .env contents.

What happens after your first merge

Thanks for writing the code. We're building this to last.

@abhicris

Copy link
Copy Markdown
Contributor

This issue/PR has had no activity for 21 days and is being closed automatically by the kcolbchain PR pipeline.

If it's still relevant, reopen or leave a comment and we'll re-triage. For the full policy see pipeline docs.

@abhicris abhicris closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants