Skip to content

Investigate (and potentially implement) informer names for BuildGenericConfig #4495

Open

Description

@SimonTheLeg

With 1.37 upstream introduced a new feature to give informers names. This is mainly used for metrics. However implementing this feature in kcp is a bit more tricky than just threading it through, so it is disabled for now. Specifically we build Configs for each of our logicalclusters and we have to ensure that their names would be unique across a full kcp installation. This is a problem upstream does not have as they essentially build one per process.

For this task we need to figure out what unqiue naming we could use, then revert our changes in UPSTREAM: <carry>: generic cleanup to implement this feature for generic configs.

All of these I did not want to be doing in the rebase itself, so it is disabled for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    • Status
      New

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions