[souvik-biswas-dev]

Summary

Adds e2e coverage proving that an authorization webhook decision cannot
get around the authz gates introduced in #4507:

• A webhook Allow for a user outside the workspace's required groups
  still ends in Forbidden (required-groups gate).
• A webhook Allow for update/patch on apiexports/status and
  apibindings/status still ends in Forbidden (system CRD gate).
• A webhook Deny ends in Forbidden even for a user RBAC would admit
  (webhook ordered ahead of RBAC).

Each case has a control step showing the webhook grant works where no
gate applies. I also checked that the tests fail when the corresponding
gate is disabled.

I did not extract the closure into a chainAuthorizer function (marked
optional in the issue). Happy to follow up with that and a unit test.

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #4512

Release Notes

NONE

[kcp-ci-bot]

Hi @souvik-biswas-dev. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mjudeikis]

Once #4507 is merged this needs rebase . Moving to draft for now. 4507 is tagged so should be ok to rebase in few minutes

[souvik-biswas-dev]

Rebased onto main now that #4507 has merged; the PR is down to the single test file. Could someone with org access run /ok-to-test?

One heads-up: these tests use framework.SerialSuite since they start their own server. I noticed a few other tests (e.g. TestMaximalPermissionPolicyWebhookEscalation) still use framework.Suite(t, "control-plane"), which I couldn't find enabled anywhere in the Makefile or CI config, so they may be getting skipped. Happy to open a separate issue if that's useful.

[souvik-biswas-dev]

/kind cleanup

[ntnn]

/ok-to-test

[ntnn]

/lgtm
/approve

Thanks!

[kcp-ci-bot]

LGTM label has been added.

Details

Git tree hash: f0a5222113d9e72a36954680208d3cd285788e04

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ntnn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment