[mjudeikis-bot]

Summary

Restores the local Secret getter in pkg/server/serviceaccount/cache.go to a plain lister read (secretsLister.Secrets(namespace).Get(name)). The live GET fallback added in #4528 on every lister miss is removed, so a missing Secret (e.g. a stale or bogus token reference) no longer costs a request to the shard per call.

Note on the issue's premise: shardlookup.Lookup.Get (pkg/shardlookup/lookup.go) sends local keys only to the local func and non-local keys only to the TTL-cached fetch func; fetch is not a fallback for local misses. After this change a local Secret absent from the informer returns NotFound. The Secret informer is filtered to type=kubernetes.io/service-account-token, and this getter is only used to resolve token Secrets, so that is the expected result. The one remaining edge is a token Secret created moments before the informer observes it, which fails until the informer catches up.

Requested in #4540 (comment)

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #4540

Release Notes

NONE

Tested: go build ./pkg/server/..., go vet ./pkg/server/serviceaccount/. golangci-lint is not available in my environment. No unit test added: the package has no existing tests and the getter needs cluster-aware informers to construct.

[kcp-ci-bot]

Hi @mjudeikis-bot. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ntnn]

/lgtm
/approve
/ok-to-test

[kcp-ci-bot]

LGTM label has been added.

Details

Git tree hash: 3416a6d8bb162dec9531f87980df2b3cddc47e1c

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ntnn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment