[RaphaelFakhri]

Summary

kubectl kcp bind apiexport --accept-all-permission-claims and --reject-all-permission-claims copied only the group and resource of each APIExport permission claim into the APIBinding. Claims on resources from other APIExports carry an identity hash, so the accepted claim never matched the exported claim and was not applied.

This change copies IdentityHash from the APIExport claim and moves the claim-building loop out of Run into addAllPermissionClaims so it can be unit tested. TestAddAllPermissionClaims fails without the fix and passes with it.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #4544

Release Notes

Fix `kubectl kcp bind apiexport --accept-all-permission-claims` and `--reject-all-permission-claims` dropping the identity hash of permission claims on resources from other APIExports.

[kcp-ci-bot]

Hi @RaphaelFakhri. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ntnn]

/lgtm
/approve

Thank you!

[kcp-ci-bot]

LGTM label has been added.

Details

Git tree hash: a7f0050107fa643b5a3fca34c5b0391548ef9a0b

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• staging/src/github.com/kcp-dev/cli/OWNERS [ntnn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment